Conversation
- using surface wide settings index that can have tags & locale overrides, - adding in memory cache, - keep for now 'hard coded' price literals, and collection settings, - change odinURL api to accept parameters without locale, - add unit tests
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 84.12% 84.14% +0.01%
==========================================
Files 180 180
Lines 49064 49064
==========================================
+ Hits 41276 41283 +7
+ Misses 7788 7781 -7 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| function resolveSettingEntry(fragment, locale, setting) { | ||
| const defaultEntry = setting.default; | ||
| if (!defaultEntry) return null; | ||
| if (defaultEntry.templates && !(fragment.variant in defaultEntry.templates)) return null; |
There was a problem hiding this comment.
I'm not sure if this method is covered by tests enough. is fragment.variant expected to exist? Should not it be fragment.fields.variant ?
There was a problem hiding this comment.
some bug / misfunction of the coverage tool was "covering" that second part of the test. tempaltes is supposed to be an array, and this condition was not even supposed to work! fixing & testing this
Resolves https://jira.corp.adobe.com/browse/MWPW-166756
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
Test URLs: