Skip to content

MWPW-166756 [mas/io] dynamic settings#613

Open
npeltier wants to merge 18 commits intomainfrom
MWPW-166756
Open

MWPW-166756 [mas/io] dynamic settings#613
npeltier wants to merge 18 commits intomainfrom
MWPW-166756

Conversation

@npeltier
Copy link
Contributor

  • using surface wide settings index that can have tags & locale overrides,
  • adding in memory cache,
  • keep for now 'hard coded' price literals, and collection settings,
  • add unit tests

Resolves https://jira.corp.adobe.com/browse/MWPW-166756
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

Test URLs:

- using surface wide settings index that can have tags & locale overrides,
- adding in memory cache,
- keep for now 'hard coded' price literals, and collection settings,
- change odinURL api to accept parameters without locale,
- add unit tests
@aem-code-sync
Copy link

aem-code-sync bot commented Feb 20, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (146a3bf) to head (53b9efc).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #613      +/-   ##
==========================================
+ Coverage   84.12%   84.14%   +0.01%     
==========================================
  Files         180      180              
  Lines       49064    49064              
==========================================
+ Hits        41276    41283       +7     
+ Misses       7788     7781       -7     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146a3bf...53b9efc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

function resolveSettingEntry(fragment, locale, setting) {
const defaultEntry = setting.default;
if (!defaultEntry) return null;
if (defaultEntry.templates && !(fragment.variant in defaultEntry.templates)) return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this method is covered by tests enough. is fragment.variant expected to exist? Should not it be fragment.fields.variant ?

Copy link
Contributor Author

@npeltier npeltier Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some bug / misfunction of the coverage tool was "covering" that second part of the test. tempaltes is supposed to be an array, and this condition was not even supposed to work! fixing & testing this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fixed)

@npeltier npeltier added run nala and removed run nala labels Mar 6, 2026
@aem-code-sync aem-code-sync bot temporarily deployed to MWPW-166756 March 6, 2026 14:20 Inactive
@npeltier npeltier removed the run nala label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants