Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
==========================================
+ Coverage 84.15% 85.49% +1.33%
==========================================
Files 180 188 +8
Lines 49064 53927 +4863
==========================================
+ Hits 41292 46103 +4811
- Misses 7772 7824 +52
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| target.dispatchEvent(closeEvent); | ||
| }; | ||
|
|
||
| #handleBackToBreadcrumb = () => { |
There was a problem hiding this comment.
I moved breadcrumb to top-nav as per Figma.
| form = Object.fromEntries([...this.fragment.fields.map((f) => [f.name, f])]); | ||
| } | ||
| return html` | ||
| <div class="promotions-form-breadcrumb"> |
There was a problem hiding this comment.
I moved breadcrumb to top nav as per Figma
| @@ -0,0 +1,143 @@ | |||
| import { css, html, LitElement } from 'lit'; | |||
There was a problem hiding this comment.
I extracted quantity-select as a field so that I could also use it in settings UI as a setting.
|
@yesil i am not able to select template in Create Settings nor in override. It is greyed out. 
|
|
@yesil for the quantity selector in the editor you have removed a lot of testable attributes and uniqueness of the fields, causing Nala to fail. Removing aria-label value also might have accessibility consequences. Do we really want to strip all these? It is hard to make selectors now unique for the field without any identifier. your branch: prod: |
| */ | ||
| export const SETTING_NAME_DEFINITIONS = [ | ||
| { name: 'addon', valueType: 'optional-text', editor: 'addon' }, | ||
| { name: 'secureLabel', valueType: 'boolean' }, |
There was a problem hiding this comment.
this should ideally be optional-text with editor either text or placeholder
There was a problem hiding this comment.
I renamed placeholder to addon, since it was displaying only addon placeholders.
I'll use text editor, later we can check if needed.
5 participants
Settings UI will appear only if you are either a MAS Admin or MAS Poweruser.
In the test URL, I have
mas-io-studio-baseso that user groups are also available for access to Setting feature.However, it does not need any app builder deployment. Once
scripts/app/refreshUsers.mjsis merged, user groups will become available on main after next sync.Resolves https://jira.corp.adobe.com/browse/MWPW-188000
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: