Conversation
# Conflicts: # libs/features/mep/lingo.js # libs/utils/utils.js # test/blocks/fragment/fragment.test.js
# Conflicts: # libs/blocks/merch/merch.js
# Conflicts: # libs/blocks/caas/utils.js # libs/blocks/fragment/fragment.js # libs/blocks/merch/merch.js # libs/features/georoutingv2/georoutingv2.js
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
vhargrave
changed the title
vhargrave
requested review from
a team,
Ruchika4,
bandana147,
chrischrischris,
cmiqueo,
sanrai and
vgoodric
as code owners
echen-adobe
left a comment
echen-adobe
left a comment
There was a problem hiding this comment.
Had some nits, other than that looks good.
|
Reminder to set the |
aem-code-sync
bot
temporarily deployed
to
vhargrave/lingo-update-milocore-features
aem-code-sync
bot
temporarily deployed
to
vhargrave/lingo-update-milocore-features
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
narcis-radu
left a comment
narcis-radu
left a comment
There was a problem hiding this comment.
Thank you for making everyone's life very hard 😬. Let's test this properly and ensure there are no issues.
5 participants
Add fallback for getCountry and make it async
Resolves: MWPW-189212
Test URLs:
Before: https://main--milo--adobecom.aem.page/?martech=off
After: https://vhargrave-lingo-update-milocore-features--milo--adobecom.aem.page/?martech=off
Before: https://main--cc--adobecom.aem.live/products/photoshop?georouting=on
After: https://main--cc--adobecom.aem.live/products/photoshop?milolibs=vhargrave-lingo-update-milocore-features&georouting=on
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale