Improve the variable name 'customUrl' to 'testDependencyUrl'#812
Merged
smlambert merged 1 commit intoadoptium:masterfrom Mar 11, 2026
Merged
Conversation
Amrutha-Kanhirathingal
force-pushed
the
renameCustomUrl
branch
from
a469239 to
a41c659
Compare
Contributor
Author
Amrutha-Kanhirathingal
changed the title
Contributor
Author
|
Hi @annaibm ,@smlambert could you please review the changes? |
annaibm
reviewed
Mar 4, 2026
scripts/getDependencies.pl
Outdated
| } | ||
| } | ||
| my $url_custom = $customUrl; | ||
| my $url_custom = $testDependencyUrl; |
Contributor
There was a problem hiding this comment.
for consistency, I think we should rename $url_custom to $url_testDependency or a more descriptive name like $testDependencyUrl (matching the new variable name).
Contributor
Author
There was a problem hiding this comment.
Sure,Thanks
Contributor
Author
There was a problem hiding this comment.
Changed url_custom to url_testDependency and also updated the log messages.Kindly have a look .Thanks
karianna
approved these changes
Mar 7, 2026
Contributor
|
@Amrutha-Kanhirathingal Could you please squash the commits? |
Renamed customUrl variable name to testDependencyUrl Related :adoptium/aqa-tests#6461 Closes :adoptium/aqa-tests/#6865 Signed-off-by: Amrutha Kanhirathingal <Amrutha.Kanhirathingal@ibm.com> Renamed url_custom variable to url_testDependency
Amrutha-Kanhirathingal
force-pushed
the
renameCustomUrl
branch
from
2ecd00f to
1f950d4
Compare
smlambert
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed customUrl to testDependencyUrl
Related :adoptium/aqa-tests#6461
Closes :adoptium/aqa-tests#6865