Added handling for MathML markup#278
Merged
kelockhart merged 3 commits intoadsabs:masterfrom Jul 3, 2025
Merged
Conversation
tjacovich
approved these changes
Jul 3, 2025
tjacovich
left a comment
There was a problem hiding this comment.
I think this seems reasonable, just one question about where the LaTeX converter lives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were passing MathML markup along in the export, without any special handling. This is especially problematic in LaTeX formats (including BibTeX), because the markup breaks the LaTeX compilation on the user's end.
Example (2020EPJC...80...96D; 2024EPJC...84..487P is another example):
This PR does the following:
encode_laTexfunction)Notes: