BibTeX support for doctype techreport#285
Merged
ehenneken merged 2 commits intoadsabs:masterfrom Aug 26, 2025
Merged
Conversation
kelockhart
approved these changes
Aug 26, 2025
Member
kelockhart
left a comment
kelockhart
left a comment
There was a problem hiding this comment.
One very minor thing about the code comments, but otherwise looks good to me!
exportsrv/formatter/bibTexFormat.py
Outdated
| @@ -177,12 +185,11 @@ def __get_fields(self, a_doc): | |||
| ('aff', 'school'), ('year', 'year'), ('month', 'month'), | |||
| ('bibcode', 'adsurl'),('adsnotes', 'adsnote')] | |||
| # 2/14 mapping techreport and intechreport to @MISC per Markus request for now | |||
Member
There was a problem hiding this comment.
Can you remove this comment, since you've superseded it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of issue #284
When a record has doctype
techreportthe BibTeX type@TECHREPORTwill only get assigned when thepublisherfield is populated. This PR also updated the fields used for@TECHREPORT. Appropriate unittests have been implement to test this behavior.