fix(facets): show loading state instead of No Results flash

[thostetler]

Summary

• Fixed facets briefly displaying "No Results" when searching from the landing page before data loads
• Added isLoading check alongside isFetching in both NodeList and NodeListModal components
• When the facet query is initially disabled (search query not yet in state), React Query sets isLoading=true but isFetching=false, causing the empty-state branch to trigger prematurely

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.9%. Comparing base (47f0a50) to head (9d534fd).

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #818     +/-   ##
========================================
+ Coverage    61.9%   61.9%   +0.1%     
========================================
  Files         317     317             
  Lines       36549   36549             
  Branches     1642    1642             
========================================
+ Hits        22619   22621      +2     
+ Misses      13893   13891      -2     
  Partials       37      37             

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Risk summary: Low. Change is limited to UI branching logic for facet loading/empty states and should reduce an observable flicker without affecting the underlying query logic.

This PR updates the SearchFacet facet list components to avoid briefly rendering the “No Results” empty state before facet data is available (notably when the underlying React Query is initially disabled and isFetching is false).

Changes:

• Include isLoading from useGetFacetData in NodeList and NodeListModal.
• Treat isLoading the same as isFetching when deciding whether to render loading skeleton/spinner vs empty state.

---

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Optional: add a small regression test covering the new isFetching || isLoading branching (e.g., mock useGetFacetData to return isLoading: true, isFetching: false, treeData: [] and assert the loading state renders instead of the "No Results" empty state for both NodeList and NodeListModal).