Skip to content

More fixes of accessibility issues#820

Merged
thostetler merged 7 commits intoadsabs:masterfrom
shinyichen:a11y
Mar 5, 2026
Merged

More fixes of accessibility issues#820
thostetler merged 7 commits intoadsabs:masterfrom
shinyichen:a11y

Conversation

@shinyichen
Copy link
Member

This PR should take care of most accessibility issues

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 56.12245% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.9%. Comparing base (a7a0d97) to head (7ecc03c).

Files with missing lines Patch % Lines
...ents/SearchFacet/SearchFacetModal/SelectedList.tsx 6.7% 14 Missing ⚠️
...c/components/Visualizations/Widgets/PaperLimit.tsx 0.0% 9 Missing ⚠️
...rc/components/Visualizations/Graphs/BubblePlot.tsx 0.0% 4 Missing ⚠️
src/components/NavBar/FeedbackDropdown.tsx 93.2% 3 Missing ⚠️
src/components/Visualizations/Graphs/BarGraph.tsx 0.0% 2 Missing ⚠️
src/components/Visualizations/Graphs/Histogram.tsx 0.0% 2 Missing ⚠️
...onents/Pagination/ControlledPaginationControls.tsx 0.0% 1 Missing ⚠️
src/components/Pagination/PaginationControls.tsx 0.0% 1 Missing ⚠️
src/components/Tags/Tags.tsx 0.0% 1 Missing ⚠️
...sualizations/GraphPanes/AuthorNetworkGraphPane.tsx 0.0% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #820     +/-   ##
========================================
- Coverage    62.0%   61.9%   -0.0%     
========================================
  Files         317     317             
  Lines       36521   36549     +28     
  Branches     1642    1642             
========================================
+ Hits        22608   22619     +11     
- Misses      13876   13893     +17     
  Partials       37      37             
Files with missing lines Coverage Δ
src/components/BibstemPicker/BibstemPicker.tsx 63.1% <100.0%> (+0.5%) ⬆️
...onents/Visualizations/GraphPanes/WordCloudPane.tsx 31.0% <ø> (+0.6%) ⬆️
...nents/Visualizations/GraphPanes/YearsGraphPane.tsx 11.5% <ø> (+0.1%) ⬆️
src/pages/paper-form.tsx 70.6% <100.0%> (+0.5%) ⬆️
...onents/Pagination/ControlledPaginationControls.tsx 18.6% <0.0%> (-0.2%) ⬇️
src/components/Pagination/PaginationControls.tsx 18.2% <0.0%> (-0.2%) ⬇️
src/components/Tags/Tags.tsx 85.0% <0.0%> (ø)
...sualizations/GraphPanes/AuthorNetworkGraphPane.tsx 28.6% <0.0%> (ø)
...nents/Visualizations/GraphPanes/BubblePlotPane.tsx 53.9% <0.0%> (ø)
...ents/Visualizations/GraphPanes/HIndexGraphPane.tsx 11.7% <0.0%> (+0.1%) ⬆️
... and 9 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shinyichen shinyichen requested a review from thostetler March 4, 2026 21:04
Copy link
Member

@thostetler thostetler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thostetler thostetler merged commit 47f0a50 into adsabs:master Mar 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants