fix: Correct the order of data type check#36
Open
deiteris wants to merge 1 commit intoadvanced-rest-client:mainfrom
Open
fix: Correct the order of data type check#36deiteris wants to merge 1 commit intoadvanced-rest-client:mainfrom
deiteris wants to merge 1 commit intoadvanced-rest-client:mainfrom
Conversation
deiteris
force-pushed
the
fix-data-type-order
branch
from
5324f56 to
a13281a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current order results in any shape after
Anybeing unreachable, since all shapes consist ofAnyShape. This also fixesTupletype since it is a part ofArrayShape. This also removes duplicate check forUnionShape.