Open
Conversation
git-subtree-dir: dependencies/lmdb git-subtree-split: 8ad7be2510414b9506ec9f9e24f24d04d9b04a1a
matttylr
force-pushed
the
kevel/lmdb_0.9.29
branch
from
24149bc to
a55c1c5
Compare
matttylr
force-pushed
the
kevel/lmdb_0.9.29
branch
from
a55c1c5 to
b1aec5b
Compare
shooit
approved these changes
Nov 11, 2024
shooit
left a comment
shooit
left a comment
There was a problem hiding this comment.
This all looks good. I agree we will want to spend some more time with how we handle transactions but we can come back to that especially if we aren't getting burned by the cost to open a transaction.
Co-authored-by: Sam Hewitt <hewitts89@gmail.com>
Author
@shooit Bifrost opens a single transaction per request and stores that in the AsyncLocalStorage context which the Store class looks for, so we're ok atm. |
use the `auto` feature from msgpackr to unpack a 64 bit integer as a Number if it is below Number.MAX_SAFE_INTEGER, otherwise as a BigInt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.