add support for RSA private keys #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for RSA private keys. See the `mtls.RSAPrivateKey` struct. RSA keys use the `k3:` prefix and are significantly larger than EdDSA / ECDSA keys. Currently, their text representation includes the private key parameter `D` which is not strictly required since it can be re-computed using the public exponent `E`. However, due to FIPS 140, `D` would have to be computed not using the typical φ(N) where φ(N) = (p-1)(q-1) but using E⁻¹ mod λ(N) where λ(N) = lcm(p-1, q-1). This commit also adds an RSA certificate used for tests generated with OpenSSL 3.6.0 Signed-off-by: Andreas Auernhammer <github@aead.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for RSA private keys.
See the
mtls.RSAPrivateKeystruct.RSA keys use the
k3:prefix and are significantly larger than EdDSA / ECDSA keys. Currently, their text representation includes the private key parameterDwhich is not strictly required since it can be re-computed using the public exponentE. However, due to FIPS 140,Dwould have to be computed not using the typical φ(N) where φ(N) = (p-1)(q-1) but using E⁻¹ mod λ(N) where λ(N) = lcm(p-1, q-1).This commit also adds an RSA certificate used for tests generated with OpenSSL 3.6.0