Skip to content

Conversation

Copy link

Copilot AI commented Jan 27, 2026

The publish-release workflow publishes to npm without running tests or linting, creating risk of publishing broken packages if the PR process is bypassed.

Changes

  • Added npm test step before creating GitHub release and publishing to npm
  • Added npm run lint step before creating GitHub release and publishing to npm
  • Both steps run conditionally when commit is a version bump, matching existing workflow pattern

Workflow Order

- Install dependencies
- Run tests          # New
- Run linting        # New
- Create GitHub Release
- Publish to npm

This mirrors the CI workflow's quality checks, ensuring the same validation occurs before publishing regardless of how code reaches main.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: mkistler <800728+mkistler@users.noreply.github.com>
Copilot AI changed the title [WIP] Update publish-release workflow based on review feedback Add test and lint steps to publish workflow Jan 27, 2026
Copilot AI requested a review from mkistler January 27, 2026 14:36
Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@mkistler mkistler marked this pull request as ready for review January 27, 2026 16:06
@mkistler mkistler merged commit 56b2179 into mdk/publish-to-npm Jan 27, 2026
@mkistler mkistler deleted the copilot/sub-pr-73 branch January 27, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants