Skip to content

Conversation

Copy link

Copilot AI commented Jan 27, 2026

Addresses feedback from PR #73 where the workflow could leave the repository in an inconsistent state if npm publish failed after the GitHub release was already created.

Changes

  • Reordered workflow steps in .github/workflows/publish-release.yml:
    • npm publish now executes before GitHub release creation
    • GitHub release only created if npm publish succeeds
    • Updated workflow description comment to reflect new order

This ensures GitHub releases only exist when the corresponding npm package is successfully published.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: mkistler <800728+mkistler@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on revised release and publish workflows Reverse workflow order: publish to npm before creating GitHub release Jan 27, 2026
Copilot AI requested a review from mkistler January 27, 2026 14:37
@mkistler
Copy link
Contributor

I'm going to start over on this.

@mkistler mkistler closed this Jan 28, 2026
@mkistler mkistler deleted the copilot/sub-pr-73-yet-again branch January 28, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants