Skip to content

Conversation

Copy link

Copilot AI commented Jan 28, 2026

Addresses review feedback on PR #80 requesting a more precise comment for the tag verification step in the release workflow.

The git merge-base --is-ancestor check verifies that the tagged commit is reachable from main (i.e., in main's git history), not that the tag was created directly on the main branch. This allows tags on commits from feature branches that have been merged into main.

Changes:

  • Updated step name from "Ensure tag is on main" to "Verify tagged commit is in main branch history" to accurately reflect the ancestry check behavior
- name: Verify tagged commit is in main branch history
  run: |
    git fetch origin main
    if ! git merge-base --is-ancestor $GITHUB_SHA origin/main; then
      echo "Tag is not based on main. Aborting release."
      exit 1
    fi

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mkistler <800728+mkistler@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on publish workflow documentation clarity Clarify workflow step comment for commit ancestry verification Jan 28, 2026
Copilot AI requested a review from mkistler January 28, 2026 16:13
@mkistler
Copy link
Contributor

Applied directly to #80.

@mkistler mkistler closed this Jan 28, 2026
@mkistler mkistler deleted the copilot/sub-pr-80 branch January 28, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants