Skip to content

Conversation

@mkistler
Copy link
Contributor

This is a third attempt at a publish workflow for this project.

The prior attempt would have been AWESOME, except for the snag described in #82. The suggested fix in #82 is to use PATs, but I'm not keen on that since they need to be updated every 90 days.

So this new workflow combines the actions of tagging and releasing into one workflow.

Hoping that the third time is a charm here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a third attempt at a publish workflow by consolidating the tagging and release process into a single workflow. Instead of using separate workflows (auto-tag and release) which had issues with GitHub's GITHUB_TOKEN not triggering subsequent workflows, this approach combines both operations into the release.yaml workflow that triggers on package.json changes to main.

Changes:

  • Removed the auto-tag.yaml workflow entirely
  • Modified release.yaml to trigger on package.json changes instead of tag pushes, and added tag creation before publishing
  • Updated RELEASING.md to document the new unified workflow process

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File Description
.github/workflows/auto-tag.yaml Deleted - functionality merged into release.yaml
.github/workflows/release.yaml Changed trigger from tag push to package.json changes; added version extraction, tag existence check, and tag creation steps
RELEASING.md Updated documentation to reflect unified workflow; removed references to separate auto-tag workflow; added Development Workflow section
scripts/prepare-release.sh Added blank line (cosmetic change)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'm fine with anything. Do you know what you're doing differently from aep-lib-ts? I was able to publish that without having to mess around with PATs or custom scripts.

@mkistler mkistler merged commit a6241b0 into main Jan 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants