Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 9808baf in 1 minute and 31 seconds. Click for details.
- Reviewed
217lines of code in9files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. branch_diff_commits_test.go:37
- Draft comment:
Consider using assert.NoError(t, err) consistently instead of assert.Equal(t, err, nil) for clearer error assertions. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
2. current_branch.go:18
- Draft comment:
Consider trimming the output from runGitCommand (e.g. for symbolic-ref) to avoid inadvertent whitespace issues in branch names. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. testdata/setup_test_repos.sh:5
- Draft comment:
The echo message mentions 'commits_on_branch_test' while the clone is done into 'commits_on_branch'; updating this for clarity is recommended. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
Workflow ID: wflow_iydCxHEZjPeBtS2s
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Handle detached HEAD state in Git operations and add corresponding tests.
CurrentBranch()incurrent_branch.gonow returns 'HEAD' as the branch name in detached HEAD state.BranchDiffCommits,CommitsBetween,CommitsOnBranch, andLatestCommitOnBranchfunctions now handle detached HEAD state correctly.TestCurrentBranchDetachedHeadincurrent_branch_test.goto verify behavior in detached HEAD state.TestBranchDiffCommitsDetachedHeadinbranch_diff_commits_test.goto testBranchDiffCommitswith detached HEAD.TestCommitsBetweenDetachedHeadincommits_between_test.goto testCommitsBetweenwith detached HEAD.TestCommitsOnBranchDetachedHeadincommits_on_branch_test.goto testCommitsOnBranchwith detached HEAD.TestLatestCommitOnBranchDetachedHeadinlatest_commit_on_branch_test.goto testLatestCommitOnBranchwith detached HEAD.detached_head.bundletotestdataand updatedsetup_test_repos.shto include it.This description was created by
for 9808baf. You can customize this summary. It will automatically update as commits are pushed.