Open
Conversation
…r SELL_SHORT, update import schemas to exclude non-negative check for SELL_SHORT.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Enable Short Position Tracking via Negative Quantity
This PR introduces the ability to track short positions within the portfolio by allowing SELL_SHORT transaction quantities to be negative.
#339
Implementation Details
I've updated the relevant logic to handle negative quantities, treating them as short sales. This allows users to accurately represent short positions in their holdings data.
Testing and Scope
I've performed testing across key areas, and confirmed the following components are functioning correctly with negative quantities:
Performance Chart: Calculations correctly reflect P/L and value changes for short positions.
Data Import: Importing transactions with negative quantities works as expected.
Holdings View: Displays short positions and current values accurately.
Holdings View: Limitation on displaying short position for Country Allocation and Sector Allocation (showing 0%)
Design Discussion: Negative Quantity Direction
I noticed existing guarding code against negative quantities. This implementation uses the negative quantity as the primary signal for a short position. While functional, this might conflict with existing architectural assumptions or planned future features. I am completely open to discussing alternative approaches. Do let me know your thoughts!