Increase default decimal precision#542
Closed
glowacki-dev wants to merge 3 commits intoafadil:mainfrom
Closed
Conversation
Owner
|
is it possible to update this PR? |
Owner
|
done in v3.0.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default harcoded decimal precision of 6 becomes problematic when tracking cryptocurrency transactions. Lots of them are divisible with a higher precision which causes small rounding errors when tracking values and holdings.
Most of the time it would be negligible (it would be sub-cent difference) but a difference of 0.000001 BTC is roughly $0.1 which can add up to significant numbers with multiple transactions.
Changes made:
This PR isn't a real fix for the underlying issue - to do this the precision should probably be user-configurable or automatically determined based on tracked assets. It makes the issue less annoying though and lays some groundwork for allowing proper configuration for this value