Skip to content

Fix ActivityNotFound crash on local HTML files #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnlon wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ActivityNotFound crash on local HTML files #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions app/src/main/java/com/gmail/afonsotrepa/pocketgopher/gopherclient/HtmlPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,17 @@ public void run()
{
try
{
// attempt file connect/download (possible IOEXception)
Connection conn = new Connection(page.server, page.port);
conn.getBinary(page.selector, file);

// attempt view intent (possible ActivityNotFoundException)
Intent intent = new Intent(Intent.ACTION_VIEW);
intent.addCategory(Intent.CATEGORY_BROWSABLE);
intent.setData(Uri.fromFile(file));
context.startActivity(intent);
}
catch (final IOException e)
catch (final IOException | ActivityNotFoundException e)
{
e.printStackTrace();
//inform the user of the error
Expand All @@ -139,11 +145,6 @@ public void run()
}
});
}

Intent intent = new Intent(Intent.ACTION_VIEW);
intent.addCategory(Intent.CATEGORY_BROWSABLE);
intent.setData(Uri.fromFile(file));
context.startActivity(intent);
}
}).start();
}
Expand All @@ -155,4 +156,4 @@ public void run()
Toast.makeText(context, e.getMessage(), Toast.LENGTH_LONG).show();
}
}
}
}