Export to .glb with embedded images.#553
Export to .glb with embedded images.#553fernandojsg merged 3 commits intoaframevr:masterfrom donmccurdy:feat-export-glb
Conversation
|
@donmccurdy after a quick pass I've just tried it and it "works" but the .glb file contains just But I don't get any error because of #552 I can't reproduce it /cc @dmarcos @ngokevin any idea what could be causing it? |
|
@donmccurdy I believe one of the needed steps is to update |
|
Ok, I think this is working now — updated GLTFExporter, marked inspector helpers (see #523 (comment)), and filtered them out while exporting. |
|
i had some time to test this! and it works fine |
|
Yeah, thanks for remind me I forgot about this one! Thanks @donmccurdy and @arpu |
|
@donmccurdy if i use |
|
Texture repeat, rotation, and offset are not part of the core glTF spec, but require a very recent extension. The THREE.GLTFLoader implementation has not been merged yet (mrdoob/three.js#13831), and no PR for THREE.GLTFExporter exists yet. EDIT: The wrapS / wrapT part should already be supported, though: https://github.com/mrdoob/three.js/blob/dev/examples/js/exporters/GLTFExporter.js#L740-L741 |
@fernandojsg I believe this PR fixes #547 and fixes #551, but due to #552 I am not sure how to test this locally.