Refonte - Trésorerie > Journal > Ajout/Edition #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgreb
force-pushed
the
refacto/accounting-journal-add-edit
branch
2 times, most recently
from
72a30ee to
8d9992d
Compare
vgreb
force-pushed
the
refacto/accounting-journal-add-edit
branch
from
8d9992d to
d23e6d7
Compare
vgreb
requested review from
Mopolo and
stakovicz
and removed request for
stakovicz
Mopolo
reviewed
Jan 15, 2026
| * @return CollectionInterface<Event> | ||
| */ | ||
| public function getAllSortedByName(): CollectionInterface | ||
| public function getAllSortedByName($usedInAccountingJournal = false): CollectionInterface |
Contributor
There was a problem hiding this comment.
Suggested change
| public function getAllSortedByName($usedInAccountingJournal = false): CollectionInterface | |
| public function getAllSortedByName(bool $usedInAccountingJournal = false): CollectionInterface |
| public function getNextTransaction(int $transactionId): ?Transaction | ||
| { | ||
| $query = $this->getQuery('SELECT * FROM compta WHERE (idcategorie = :undeterminedCategoryId OR idevenement = :undeterminedEventId) AND id > :transactionId ORDER BY id ASC LIMIT 1'); | ||
| $query->setParams(['transactionId' => $transactionId, 'undeterminedCategoryId' => 26, 'undeterminedEventId' => 8]); |
Contributor
There was a problem hiding this comment.
On a AutoQualifier::DEFAULT_CATEGORIE et AutoQualifier::DEFAULT_EVENEMENT pour les ids en dur.
| } | ||
|
|
||
| public function setPaymentComment(string $paymentComment): self | ||
| public function setPaymentComment(?string $paymentComment): self |
Contributor
There was a problem hiding this comment.
Faut faire pareil sur le getter du coup si c'est nullable.
| $form = $this->createForm(TransactionType::class, $transaction, ['operation' => 'edit', 'nextTransaction' => $nextTransaction]); | ||
| $form->handleRequest($request); | ||
| if ($form->isSubmitted() && $form->isValid()) { | ||
| /** @var SubmitButton|null $passButton */ |
Contributor
There was a problem hiding this comment.
Je pense pas que ce soit utile ça vu qu'il y a un instanceof juste en dessous.
Pareil pour l'autre @var ligne 46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2107