chore: update dependencies and improve security in code execution (#49)#51
chore: update dependencies and improve security in code execution (#49)#51frontegg-david merged 1 commit intomainfrom
Conversation
* chore: update dependencies and improve security in code execution * chore: update auto_review base branches to support regex pattern matching * fix: improve code clarity and enforce security measures in worker scripts
📝 WalkthroughWalkthroughConfiguration restructured for CodeRabbit auto-reviews; package versions and dependencies bumped across workspace libraries and root toolchain; code wrapping mechanisms refactored from template literals to string concatenation; worker pool memory handler improved with explicit cleanup; custom globals tracking added to Enclave core logic. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.coderabbit.yaml:
- Around line 5-8: Remove the default branch entry "main" from the auto_review
-> base_branches list; update the base_branches setting so it only contains
non-default patterns (e.g., "release/.*") and no longer includes "main" to match
CodeRabbit's expectation that base_branches are extra base branches besides the
repository default.
🧹 Nitpick comments (1)
libs/core/src/__tests__/worker-pool-adapter.spec.ts (1)
379-398: Ensureenclave.dispose()runs even on assertion failure.Wrap the test body in
try/finallyso workers are cleaned up even if an assertion throws.Proposed change
- const result = await enclave.run(` - async function __ag_main() { - return { - value: customValue, - }; - } - `); - - expect(result.success).toBe(true); - expect(result.value).toEqual({ value: 42 }); - - enclave.dispose(); + try { + const result = await enclave.run(` + async function __ag_main() { + return { + value: customValue, + }; + } + `); + + expect(result.success).toBe(true); + expect(result.value).toEqual({ value: 42 }); + } finally { + enclave.dispose(); + }
Summary by CodeRabbit
Release Notes
Bug Fixes
Chores