feat: Implement machine ID override for session continuity and add tests for create() function#234
Merged
frontegg-david merged 2 commits intomainfrom Feb 5, 2026
Merged
Conversation
…sts for create() function
Contributor
📝 WalkthroughWalkthroughAdds a flat-config Direct MCP server factory with instance caching and optional machineId override, a new server-side Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client Code
participant Factory as create()
participant Builder as buildConfig()
participant FrontMCP as FrontMcpInstance
participant Server as DirectMcpServer
Client->>Factory: create(config)
Factory->>Factory: Check instanceCache
Factory->>Builder: buildConfig(config)
Builder->>Builder: Create synthetic app and attach metadata
Builder-->>Factory: FrontMcpConfigInput
Factory->>Factory: Optional setMachineIdOverride()
Factory->>FrontMCP: createDirect(fullConfig)
FrontMCP->>Server: Instantiate & initialize
FrontMCP-->>Factory: Promise<DirectMcpServer>
Factory->>Factory: Cache with cacheKey
Factory-->>Client: Promise<DirectMcpServer>
sequenceDiagram
participant AppCode as App Code
participant Server as DirectMcpServer
participant ClientImpl as DirectClientImpl
participant Client as DirectClient
AppCode->>Server: connect(sessionId)
Server->>Server: Validate not disposed
Server->>Server: Normalize to ConnectOptions
Server->>ClientImpl: Dynamic import
Server->>ClientImpl: create(scope, options)
ClientImpl->>Client: Instantiate with scope & options
ClientImpl-->>Server: DirectClient
Server-->>AppCode: Promise<DirectClient>
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@libs/sdk/src/direct/__tests__/create.spec.ts`:
- Around line 15-25: The mockServer object is missing the required connect()
method from the DirectMcpServer interface; add a connect:
jest.fn().mockResolvedValue(<DirectClient>) (or an async function returning a
DirectClient stub) to the mockServer definition so it satisfies the
DirectMcpServer type, ensuring the method signature returns
Promise<DirectClient> and referencing the existing mockServer, DirectMcpServer
and DirectClient symbols when implementing the stub.
In `@libs/sdk/src/direct/create.ts`:
- Around line 139-143: The config.machineId override is being applied in
create() via setMachineIdOverride but never restored, making the override
process-global; update create() to scope the override by importing the
machine-id utilities, capture the current value with getMachineId() (or
equivalent), call setMachineIdOverride(config.machineId) before server
construction, then restore the original value with
setMachineIdOverride(previousValue) (or undefined) immediately after the server
is created so subsequent getMachineId() calls are unaffected.
🧹 Nitpick comments (1)
libs/sdk/src/direct/__tests__/create-e2e.spec.ts (1)
92-96: Use MCP error class instead of generic Error in the test guard.
Keep error handling consistent with SDK conventions even in tests.♻️ Suggested change
import { z } from 'zod'; +import { InternalMcpError } from '../../errors'; @@ - if (!echoTool) throw new Error('echoTool not found'); + if (!echoTool) throw new InternalMcpError('echoTool not found');As per coding guidelines: Use specific error classes with MCP error codes instead of generic errors.
Contributor
Performance Test ResultsStatus: ✅ All tests passed Summary
Total: 100 tests across 21 projects 📊 View full report in workflow run Generated at: 2026-02-05T02:51:11.306Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Tests