fix: remove hardcoded 48-character limit from text inputs by tomerqodo · Pull Request #5 · agentic-review-benchmarks/dify-combined-coderabbit

tomerqodo · 2026-01-30T02:25:09Z

Benchmark PR from agentic-review-benchmarks#5

Summary by CodeRabbit

Bug Fixes
- Input fields no longer enforce automatic character limits unless explicitly configured; text, paragraph, and number inputs will only restrict length when a limit is specified.
Tests
- Added test coverage verifying maxLength attribute behavior with and without configured limits.

coderabbitai · 2026-01-30T02:25:18Z

📝 Walkthrough

Walkthrough

The PR removes the DEFAULT_VALUE_MAX_LEN constant and eliminates fallback logic that automatically assigned default maximum length values to text inputs across the application. Components now only apply maxLength when explicitly provided via the max_length property.

Changes

Cohort / File(s)	Summary
Configuration Type Change Handling `web/app/components/app/configuration/config-var/config-modal/index.tsx`, `web/app/components/app/configuration/config-var/index.tsx`	Removed automatic `max_length` assignment when input type changes to paragraph; deleted `DEFAULT_VALUE_MAX_LEN` import and related fallback logic.
Input Field Rendering `web/app/components/app/configuration/debug/chat-user-input.tsx`, `web/app/components/app/configuration/prompt-value-panel/index.tsx`	Updated `maxLength` props to use `max_length` directly without fallback to default constant; removed `DEFAULT_VALUE_MAX_LEN` imports.
RAG Pipeline Form Handling `web/app/components/rag-pipeline/components/panel/input-field/editor/form/hooks.ts`, `web/app/components/rag-pipeline/components/panel/input-field/editor/form/index.spec.tsx`	Removed `maxLength` assignment during type change to paragraph in hook; deleted corresponding test case verifying default length assignment.
Text Generation Components `web/app/components/share/text-generation/index.tsx`, `web/app/components/share/text-generation/run-once/index.tsx`	Replaced `max_length \|\| DEFAULT_VALUE_MAX_LEN` fallback logic with direct `max_length` usage; removed constant import.
Test Suite for maxLength Behavior `web/app/components/share/text-generation/run-once/index.spec.tsx`	Added new tests verifying that `maxLength` is only applied when `max_length` is explicitly set on variables.
Default Templates and Utilities `web/config/index.ts`, `web/utils/var.ts`	Removed `max_length` property from exported template objects; updated variable utility to preserve `max_length` in returned objects instead of filtering it out.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A constant removed with careful care,
Defaults fall away like spring-time air,
Now maxLength flows where set, nowhere else,
Each input speaks true—no hidden bells! 🔔

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The provided description is insufficient and does not follow the repository's PR template structure, missing required sections like Summary, Screenshots, and proper issue linking.	Complete the PR description following the template: add a detailed summary explaining the change and issue being fixed, include before/after screenshots if applicable, and ensure proper issue linking using 'Fixes #'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically describes the main change: removing a hardcoded 48-character limit from text inputs, which is the core objective across multiple files in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch coderabbit_full_head_fix_remove_hardcoded_48-character_limit_from_text_inputs_pr5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tomerqodo · 2026-01-30T16:33:52Z

@coderabbitai review

coderabbitai · 2026-01-30T16:33:57Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

tomerqodo · 2026-01-30T16:37:19Z

@coderabbitai review

coderabbitai · 2026-01-30T16:37:30Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

tomerqodo · 2026-01-30T16:39:56Z

@coderabbitai review

coderabbitai · 2026-01-30T16:40:05Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ravidqodo · 2026-02-02T10:02:30Z

@coderabbitai review

coderabbitai · 2026-02-02T10:02:39Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

ravidqodo · 2026-02-02T11:02:33Z

@coderabbitai review

coderabbitai · 2026-02-02T11:02:43Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@web/app/components/share/text-generation/index.tsx`:
- Line 199: Remove the debug console.log call used during batch validation:
delete the console.log('Checking batch inputs:', { dataLength: data.length,
headerData }) statement in web/app/components/share/text-generation/index.tsx
(the batch validation block referencing variables data and headerData); if you
want to keep debug info for development only, wrap any logging behind a dev-only
guard (e.g., check process.env.NODE_ENV === 'development') instead of leaving
console.log in production client code.

coderabbitai · 2026-02-02T11:10:52Z

web/app/components/share/text-generation/index.tsx

      return false
    }
    const headerData = data[0]
+    console.log('Checking batch inputs:', { dataLength: data.length, headerData })


⚠️ Potential issue | 🟡 Minor

Remove debug logging from batch validation.
console.log in client code can leak user data into the console and adds noise. Please remove it or guard it behind a dev-only flag.

🧹 Suggested fix

- console.log('Checking batch inputs:', { dataLength: data.length, headerData })

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

console.log('Checking batch inputs:', { dataLength: data.length, headerData })

🤖 Prompt for AI Agents

In `@web/app/components/share/text-generation/index.tsx` at line 199, Remove the debug console.log call used during batch validation: delete the console.log('Checking batch inputs:', { dataLength: data.length, headerData }) statement in web/app/components/share/text-generation/index.tsx (the batch validation block referencing variables data and headerData); if you want to keep debug info for development only, wrap any logging behind a dev-only guard (e.g., check process.env.NODE_ENV === 'development') instead of leaving console.log in production client code.

tomerqodo added 2 commits January 25, 2026 12:04

Apply PR changes (squashed due to cherry-pick conflicts)

3eeed81

update pr

fc5f36e

coderabbitai bot reviewed Feb 2, 2026

View reviewed changes

Conversation

tomerqodo commented Jan 30, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

tomerqodo commented Jan 30, 2026

Uh oh!

coderabbitai bot commented Jan 30, 2026

Uh oh!

tomerqodo commented Jan 30, 2026

Uh oh!

coderabbitai bot commented Jan 30, 2026

Uh oh!

tomerqodo commented Jan 30, 2026

Uh oh!

coderabbitai bot commented Jan 30, 2026

Uh oh!

ravidqodo commented Feb 2, 2026

Uh oh!

coderabbitai bot commented Feb 2, 2026

Uh oh!

ravidqodo commented Feb 2, 2026

Uh oh!

coderabbitai bot commented Feb 2, 2026

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tomerqodo commented Jan 30, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 30, 2026 •

edited

Loading