Skip to content

Code Review Bench PR #14725 - refactor(cli): disable jsonschema resolving external resources#4

Open
tomerqodo wants to merge 6 commits intobase_pr_14725_20260125_7660from
corrupted_pr_14725_20260125_7660
Open

Code Review Bench PR #14725 - refactor(cli): disable jsonschema resolving external resources#4
tomerqodo wants to merge 6 commits intobase_pr_14725_20260125_7660from
corrupted_pr_14725_20260125_7660

Conversation

@tomerqodo
Copy link

Code Review Bench PR tauri-apps#14725

Original PR Title: refactor(cli): disable jsonschema resolving external resources
Original PR Description: <!--
Before submitting a PR, please read https://github.com/tauri-apps/tauri/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines

  1. Give the PR a descriptive title.

Examples of good title:
- fix(windows): fix race condition in event loop
- docs: update example for App::show
- feat: add Window::set_fullscreen

Examples of bad title:
- fix tauri-apps#7123
- update docs
- fix bugs

  1. If there is a related issue, reference it in the PR text, e.g. closes bundler hates projects not named "app" tauri-apps/tauri#123.
  2. If this change requires a new version, then add a change file in .changes directory with the appropriate bump, see https://github.com/tauri-apps/tauri/blob/dev/.changes/README.md
  3. Ensure that all your commits are signed https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
  4. Ensure cargo test and cargo clippy passes.
  5. Propose your changes as a draft PR if your work is still in progress.
    -->

We only ever use it on the bundled schema for tauri.conf.json and it doesn't have any external resources that needs to be resolved, this removed the dependency on reqwest

Also moved this to be a OnceCell as it should never change
Original PR URL: tauri-apps#14725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants