Code Review Bench PR #14668 - Less statics#5
Open
tomerqodo wants to merge 2 commits intobase_pr_14668_20260125_9384from
Open
Code Review Bench PR #14668 - Less statics#5tomerqodo wants to merge 2 commits intobase_pr_14668_20260125_9384from
tomerqodo wants to merge 2 commits intobase_pr_14668_20260125_9384from
Conversation
This was referenced Jan 26, 2026
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Review Bench PR tauri-apps#14668
Original PR Title: Less statics
Original PR Description: Work on refactoring the globals in tauri-cli. I think this is beneficial as-is,
but it is not quite finished.This still is missing a full transition towards lazy initializedtauri_dirandfrontend_dirwhile guaranteeing not to break anything, as discussed in this comment.Completed.
Read commit-by-commit.
Original PR URL: tauri-apps#14668