Fix OpenAI content encoding for thinking parts and empty arrays#428
Open
laudney wants to merge 1 commit intoagentjido:mainfrom
Open
Fix OpenAI content encoding for thinking parts and empty arrays#428laudney wants to merge 1 commit intoagentjido:mainfrom
laudney wants to merge 1 commit intoagentjido:mainfrom
Conversation
Contributor
Author
|
Hey! I've added the missing unit tests that were flagged in the test plan:
All 32 tests in |
1c85acd to
b2dbe68
Compare
Contributor
Author
|
Rebased onto upstream main — merge conflict resolved. |
b2dbe68 to
1813e02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:thinkingContentParts in the OpenAI encoder — reasoning models (e.g. gpt-oss on vLLM) emit chain-of-thought thinking parts that have no OpenAI encoding. The catch-all returns nil, but an explicit clause makes intent clear.""— when all parts are filtered (e.g. assistant message with only:thinkingbefore tool calls),content: []is rejected by vLLM's strict Pydantic validation. Now normalizes to""instead.Test plan
:thinkingcontent part encoding