-
Notifications
You must be signed in to change notification settings - Fork 279
fix(rag): Exclude jackson3 from elasticsearch-java9 #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @guanxuc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical dependency conflict within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a dependency conflict by excluding Jackson 3 artifacts, which are transitively introduced by elasticsearch-java. The fix is correct, but I've suggested a more robust way to exclude all potential Jackson 3 artifacts to prevent similar issues in the future.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: Yukina <rainyu@apache.org>
|
@AlbumenJ @guanxuc All jsonschema-generator dependencies that include jackson-core should exclude jackson-core —this applies to the agent-core and agent-parent modules. This is a blocking bug that prevents the documentation demos from running normally. @chickenlj |
AgentScope-Java Version
1.0.9
Title
fix(agentscope-all): Exclude
jackson-corefromjsonschema-generatorDescription
Fixes: #728
Root Cause
The
jackson-coredependency conflict causedjava.lang.NoSuchMethodErrorerror when callingreactor.core.publisher.FluxCreate.SerializedFluxSink#next. However, this error was not handled, leading to system hang.The following error:
"java.lang.NoSuchMethodError: 'void com.fasterxml.jackson.core.base.ParserMinimalBase.<init>(com.fasterxml.jackson.core.StreamReadConstraints)'"Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)