-
Notifications
You must be signed in to change notification settings - Fork 464
Fix rp1 camera #1436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix rp1 camera #1436
Conversation
kraj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will be good to apply the needed patches on top of upstream libcamera, is that possible ?
3c01556 to
a7ca7da
Compare
|
@gizahNL This looks fine to me the way it is. Could you check the commits and clean them up a bit using the guidelines in https://meta-raspberrypi.readthedocs.io/en/latest/contributing.html. For example, the Signed-Off-By missing footers. |
@kraj it’s not. The raspberry libcamera repo is a fork and is required to be used with raspberry pi Linux kernel. The mainline libcamera only works when using mainline Linux kernel, and vice versa. Unclear why the two aren’t in sync. @gizahNL you’re not setting the ipas build flag, which means you’re running the plugin in a sandbox; lower perf. Setting pipeline to auto also adds all, when you only need one of two. Preferable is only set one based on machine. It will enumerate all at runtime for each call; enable debug logs to see behavior. I came up with similar recipes two days ago; didn’t see this issue, yet they’re a bit less. No disable warnings, etc; it builds fine. |
|
My PR: #1517 |
It's set at line 28 & 30 of the libcamera bbappend ;) |
a7ca7da to
ec9da92
Compare
Signed-off-by: Gijs Peskens <gijs.peskens@munisense.com>
These contain changes not yet in libcamera upstream supporting rpi/pisp, required for RPi5/CM5 camera support. Signed-off-by: Gijs Peskens <gijs.peskens@munisense.com>
Signed-off-by: Gijs Peskens <gijs.peskens@munisense.com>
ec9da92 to
fa1e385
Compare
|
@agherzan PTAL |
Fixes #1303
- What I did
Use RPI foundation libcamera, install libpisp, upgrade libcamera-apps
Please take a look whether this is the best way to integrate this.