migrate to new maven central publishing #21
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from legacy Maven Central publishing setup to a more modern publishing configuration, also updating copyright notices to 2025 and removing an obsolete library.
- Updates from old Kordamp/Nexus publishing plugins to newer Gradle Maven Publish Plugin
- Upgrades Gradle from 6.5 to 8.8 and modernizes GitHub Actions workflows
- Removes the deprecated Grails Job Testing Support library entirely
Reviewed Changes
Copilot reviewed 46 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| settings.gradle | Replaces plugin management block with buildscript dependencies for new publishing approach |
| gradle.properties | Updates Kordamp version and switches to Maven Central publish plugin |
| gradle/wrapper/gradle-wrapper.properties | Upgrades Gradle wrapper from 6.5 to 8.8 |
| .github/workflows/* | Modernizes CI workflows with newer Java and action versions |
| libs/grails-job-testing-support/* | Completely removes this library module |
| Multiple source files | Updates copyright year from 2021 to 2025 |
| docs/guide/src/docs/asciidoc/index.adoc | Removes documentation for deleted library and updates repository references |
| mavenCentral() | ||
| gradlePluginPortal() |
There was a problem hiding this comment.
[nitpick] Adding mavenCentral() as the first repository is good practice, but consider if gradlePluginPortal() should also be first since it's typically the primary source for Gradle plugins.
| mavenCentral() | |
| gradlePluginPortal() | |
| gradlePluginPortal() | |
| mavenCentral() |
| classpath "org.kordamp.gradle:guide-gradle-plugin:$kordampVersion" | ||
| classpath "org.kordamp.gradle:coveralls-gradle-plugin:$kordampVersion" | ||
| classpath 'org.ajoberstar:gradle-git-publish:2.1.3' | ||
| classpath "com.vanniktech:gradle-maven-publish-plugin:$mavenCentralPublishPluginVersion" |
There was a problem hiding this comment.
The variable mavenCentralPublishPluginVersion is referenced but not defined in this file. Ensure this variable is properly defined in gradle.properties or consider using a hardcoded version for clarity.
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip |
There was a problem hiding this comment.
[nitpick] Consider using the 'all' distribution instead of 'bin' (gradle-8.8-all.zip) to include sources and documentation, which can be helpful for IDE integration and debugging.
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip | |
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-all.zip |
No description provided.