Fix correct placement of libraries in the linker command line.#1
Open
udif wants to merge 1 commit intoagordon:masterfrom
Open
Fix correct placement of libraries in the linker command line.#1udif wants to merge 1 commit intoagordon:masterfrom
udif wants to merge 1 commit intoagordon:masterfrom
Conversation
|
true |
|
Please, accept this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original Makefile used LDFLAGS to specify link linbaries.
This caused the libraries to be specified BEFORE the object files referencing them, causing link failures.
By using LDLIBS, all the libraries are specified AFTER the object files, correcting the issue.
Tested on Ubuntu 20.04 LTS