-
-
Notifications
You must be signed in to change notification settings - Fork 280
Better relationship naming #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better relationship naming #453
Conversation
3820ad4 to
65e8f31
Compare
06a6678 to
4ad39ff
Compare
|
I'll try to get this reviewed on Monday. |
Updated version header and improved formatting for clarity.
agronholm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and one trivial change.
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
|
@agronholm whenever you have the time, please re-review my latest fixes |
agronholm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looks good. I didn't go through this latest change with a fine-toothed comb, but it seems like a good bunch of improvements. We'll do further changes if we find a problem with it.
10x. I tidied up the code a bit. There's still an issue with collissions on M2O, But that'll be for a different PR |
Changes
Fixes #377
Uses FK name for relationship names
Checklist
If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):
tests/) which would fail without your patchCHANGES.rst).If this is a trivial change, like a typo fix or a code reformatting, then you can ignore
these instructions.
Updating the changelog
If there are no entries after the last release, use
**UNRELEASED**as the version.If, say, your patch fixes issue #123, the entry should look like this:
If there's no issue linked, just link to your pull request instead by updating the
changelog after you've created the PR.