Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens
--restrict-to-workdirpath validation forapply_patchand codifies the intended safety contract with integration tests.The key policy is:
Add/Update/Move tomust not escape the configured workdir (including symlink traversal).Deleteis validated as a directory-entry operation, so deleting an in-tree symlink entry is allowed (including broken symlinks), even if the symlink target points outside workdir.What Changed
WriteLikevsDelete).Behavioral Contract Covered by Tests
..parent directory escapes.Addthrough outside-pointing symlinks.Updatethrough outside-pointing symlinks.Move todestinations through outside-pointing symlinks.Testing
Ran:
cargo test --testsResult:
10 passed; 0 failed