fix: add Kosovo country support and correct Pristina iftar time#33
Open
Muhammad-Zohaib007 wants to merge 1 commit intoahmadawais:mainfrom
Open
fix: add Kosovo country support and correct Pristina iftar time#33Muhammad-Zohaib007 wants to merge 1 commit intoahmadawais:mainfrom
Muhammad-Zohaib007 wants to merge 1 commit intoahmadawais:mainfrom
Conversation
Kosovo was missing from countryMethodMap and hanafiCountries, causing two issues: 1. The country was not recognized during setup (no auto-recommendation) 2. Iftar time in Pristina showed ~2 minutes early due to wrong default calculation method being used by the Aladhan API The Islamic Community of Kosovo (BIK) officially uses the Turkey Diyanet method (method 13) for prayer time calculations, consistent with the broader Balkan region. Kosovo's ~95% Muslim population follows the Hanafi school of jurisprudence. Adds 'Kosovo', 'Kosova' (Albanian name), and 'Republic of Kosovo' to both maps. Includes tests for method and school recommendation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #29
Kosovo was missing from the country recommendation maps in src/recommendations.ts, causing two bugs:
Kosovo not recognized — getRecommendedMethod('Kosovo') returned null, so no method was auto-recommended during setup Iftar ~2 minutes early in Pristina — without a recognized country, the Aladhan API was called without the correct calculation method, producing inaccurate Maghrib times
Fixed:
The Islamic Community of Kosovo (BIK — Bashkësia Islame e Kosovës) officially uses the Turkey Diyanet method (method 13) for prayer time calculations, consistent with the broader Balkan region. Kosovo's ~95% Muslim population follows the Hanafi school.
Added Kosovo, Kosova (Albanian name), and Republic of Kosovo to:
countryMethodMap → method 13 hanafiCountries → school 1 (Hanafi)
Tests:
Added 2 new test cases covering method and school recommendation for all three Kosovo name variants. All 40 tests pass.