Hooking svgElementToPdf into jsPDF as a plug-in.#1
Open
bgribaudo wants to merge 1 commit intoahwolf:masterfrom
Open
Hooking svgElementToPdf into jsPDF as a plug-in.#1bgribaudo wants to merge 1 commit intoahwolf:masterfrom
bgribaudo wants to merge 1 commit intoahwolf:masterfrom
Conversation
With this change, code like this becomes possible:
var pdf = new jsPDF();
pdf.addSVG(svgData, 25, 50, options);
In comparison, currently something along the lines of the below is required:
var pdf = new jsPDF();
svgElementToPdf(svgData, pdf, options);
The method name "addSVG" conflicts with https://github.com/MrRio/jsPDF/blob/master/jspdf.plugin.sillysvgrenderer.js. This isn't a problem so long as we presume that the user will only use one SVG rendering plugin at a time.
Author
|
I could take this a step further and wrap the entire body of svgToPdf.js code inside an anonymous function—as is commonly done with jsPDF plugins—if that would be desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, code like this becomes possible:
In comparison, without this change, something along the lines of the below is required:
Note
The method name "addSVG" conflicts with https://github.com/MrRio/jsPDF/blob/master/jspdf.plugin.sillysvgrenderer.js. This isn't a problem so long as we presume that the user will only use one SVG rendering plugin at a time.