Open
Conversation
Contributor
Author
…to feature/dhconv_optimization
Contributor
Author
|
I added a checkpoint-load regression test in another PR, so this is no longer an issue. |
Contributor
Author
|
I added a regression test for the output from a loaded checkpoint being the same, using an input checkpoint generated from main. The test caught a bug, so it's working properly. |
1 task
mcgibbon
added a commit
that referenced
this pull request
Feb 24, 2026
These changes are used to test performance improvements in #861 Changes: - Added `asdict` and `from_dict` methods to Context - Added regression test which ensures the output of the conditional sfno after loading checkpoint data from disk is unchanged - [x] Tests added --------- Co-authored-by: W. Andre Perkins <frodre@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR changes the shape of the weight matrix in SpectralConvS2 from [group, in, out, lat] to [group, lat, out, in] so that the matrix multiplication dimensions [out, in] are the fast dimensions, with [in] being the fastest. Backwards compatibility is included for existing checkpoints.
Changes:
No public API changes
Tests added