Add tests that Distributed.context is used in all main files using fme#882
Merged
Add tests that Distributed.context is used in all main files using fme#882
Conversation
mcgibbon
commented
Feb 27, 2026
Contributor
Author
There was a problem hiding this comment.
This is mostly duplicated from the test in fme/, but I felt like it's important that fme as a package have this test, and I also felt like it's important fme tests don't access scripts. The logic needs are also slightly different because it isn't a given that the scripts here use fme, most don't.
Arcomano1234
approved these changes
Feb 27, 2026
Contributor
Arcomano1234
left a comment
Arcomano1234
left a comment
There was a problem hiding this comment.
LGTM, did a quick check to make sure there were not any other fme files that needed to be excluded what you have seems to be good. Also the tests should find everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Updated many entrypoints to call Distributed.context for proper Distributed cleanup
Added tests that ensure files with main guards contain Distributed.context() call
Tests added