Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows setting timestep_hours on the InferenceEvaluatorAggregatorConfig, which if set to a value other than 6, will modify the step selected for "step_20" metrics.
This does mean "step 20" is a lie in these cases. While not ideal, renaming this metric is also problematic because in coupled modelling we rely on reporting step 20 ocean metrics. This is more problematic than in our daily-step runs (which are still preliminary) having to remember and communicate that "step 20" really means "day 5" (which we generally understand, internally). We should rectify this in a later PR adding more configurability to select the desired lead time.
Changes:
Added timestep_hours to InferenceEvaluatorAggregatorConfig, which if set to a value other than 6, will modify the step selected for "step_20" metrics.
Tests added