Open
Conversation
jpdunc23
approved these changes
Feb 27, 2026
Member
jpdunc23
left a comment
jpdunc23
left a comment
There was a problem hiding this comment.
Looks good but I'm confused why so many testing artifacts are updated. Maybe they contain zonal images even though it isn't the focus of the particular test?
Member
There was a problem hiding this comment.
Why does this file get updated? I thought only the zonal mean files should be affected by this change.
Contributor
Author
There was a problem hiding this comment.
Yeah that is a great question visually they look similar but might be slightly different. Just to confirm to recreate these all I was supposed to do is delete test_evaluator-test_logs_labels_exist-regression.pt right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to turn off the
roll_lonfor the zonal_mean images.Changes:
roll_lon=Falsefor zonal mean gen and error plotsResolves #881