Issue997 (changing iterators to return ints from state[i])#260
Open
FlorianPommerening wants to merge 23 commits intoaibasel:mainfrom
Open
Issue997 (changing iterators to return ints from state[i])#260FlorianPommerening wants to merge 23 commits intoaibasel:mainfrom
FlorianPommerening wants to merge 23 commits intoaibasel:mainfrom
Conversation
Closed
ClemensBuechner
approved these changes
Jul 15, 2025
Contributor
ClemensBuechner
left a comment
ClemensBuechner
left a comment
There was a problem hiding this comment.
The change cleans up many parts of the code, so I like it. In most contexts, we use var_id in the calls state[var_id], which is good I think. There are some exceptions where it currently says state[var] whic I find not as clear. There's also places where var_no is used rather than var_id. Should we change these to be more consistent? But I think it's fine to merge even without doing so.
…tors, revert workflow)
Co-authored-by: Clemens Büchner <clemens.buechner@unibas.ch>
FlorianPommerening
force-pushed
the
issue997
branch
from
68c869e to
04bd50c
Compare
ClemensBuechner
approved these changes
Jul 15, 2025
Contributor
ClemensBuechner
left a comment
ClemensBuechner
left a comment
There was a problem hiding this comment.
Still looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statenow returns anintvalue when indexed with anintvariable. Indexing a state with aVariableProxystill returns aFactProxyas before. Iterating over a state with a range-based for loop is also still possible and loops overFactProxyelements as well.