remove timer.h in logging.h: logging.h does not depend on it#264
Open
guicho271828 wants to merge 2 commits intoaibasel:mainfrom
Open
remove timer.h in logging.h: logging.h does not depend on it#264guicho271828 wants to merge 2 commits intoaibasel:mainfrom
guicho271828 wants to merge 2 commits intoaibasel:mainfrom
Conversation
Member
|
Sounds good but some tests are still failing. Maybe there is another explicit include missing? |
Member
|
I don't understand the error: I tried to clone the code and compile locally but couldn't reproduce the error there. Also line 26 of landmark_factory.h is a comment for me. Is the branch maybe not up to date? You'd have to rebase it to the current main branch then. |
a36f8d0 to
67359eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor contribution.
The include statement for timer.h in logging.h is unnecessary; While logging.cc uses
g_timer, logging.h does not use Duration, Timer or their instances.landmark_heuristic.cc depended on this implicit inclusion, therefore in the commit it has a new include statement.
This style is consistent with the rest of the code base which includes timer.h only when it is necessary.