[issue1201] Check whether a configuration guarantees completeness#283
[issue1201] Check whether a configuration guarantees completeness#283grucla wants to merge 28 commits intoaibasel:mainfrom
Conversation
Co-authored-by: SimonDold <48084373+SimonDold@users.noreply.github.com>
SimonDold
left a comment
SimonDold
left a comment
There was a problem hiding this comment.
In some for-loops you use auto in others you mention the type of the elements in the loop.
It is consistent within the file but I do not know if there is one suggestion over the other.
As mentioned on discord "astar(blind(), bound=0)" produces results that are misleading for the user.
The rest looks fine to me but I am not sure about right semantics for the different open lists.
|
|
||
| bool CombiningEvaluator::dead_ends_are_reliable() const { | ||
| bool CombiningEvaluator::is_safe() const { | ||
| return all_dead_ends_are_reliable; |
There was a problem hiding this comment.
should all_dead_ends_are_reliable be renamed to all_subevaluators_are_safe then?
src/search/search_algorithm.h
Outdated
| virtual void save_plan_if_necessary(); | ||
| /* | ||
| is_complete returns true if the search algorithm cannot "overlook" any | ||
| solvable state. |
There was a problem hiding this comment.
I don't think it is about solvable states but alive states (e.g. solvable AND reachable)
astar(blind(), bound=0) does this search only overlook unsolvable states?
What about a binary counter task where each state is solvable?
4 participants
No description provided.