Open
Conversation
yapple
force-pushed
the
feature/zero-copy
branch
from
c1c9404 to
c976b9d
Compare
DwyaneShi
reviewed
Jan 29, 2026
server/transport/ucx.c
Outdated
| resp->request_id = request_id; /* be64 */ | ||
| resp->status = htobe16(status); | ||
| resp->length = htobe32(length); | ||
| resp->addr_offset = htobe32(addr_offset); |
DwyaneShi
reviewed
Jan 29, 2026
| "addr_offset: 0x%lx, length %d\n", | ||
| request_id, priskv_resp_status_str(status), status, addr_offset, value_length); | ||
| req_sync->status = status; | ||
| req_sync->value_length = value_length; |
DwyaneShi
reviewed
Jan 29, 2026
| case UCS_INPROGRESS: \ | ||
| break; \ | ||
| default: \ | ||
| default:; \ |
Collaborator
There was a problem hiding this comment.
unnecessary, could be removed
DwyaneShi
reviewed
Jan 29, 2026
| cp server/priskv-server output/ | ||
| cp client/priskv-benchmark output/ | ||
| cp client/priskv-client output/ | ||
| cp cluster/client/priskv-cluster-benchmark output/ No newline at end of file |
Collaborator
There was a problem hiding this comment.
let keep the extra newline as the last line of the file
DwyaneShi
reviewed
Jan 29, 2026
include/priskv-protocol.h
Outdated
| PRISKV_COMMAND_ALLOC = 0x08, /* alloc memory region if support zero copy */ | ||
| PRISKV_COMMAND_SEAL = 0x09, /* seal memory region*/ | ||
| PRISKV_COMMAND_ACQUIRE = 0x0a, /* acquire memory region if support zero copy */ | ||
| PRISKV_COMMAND_RELEASE = 0x0b, /* release memory region */ |
Collaborator
There was a problem hiding this comment.
let's refine the comment as "release memory region acquired for read" to eliminate confusion, since typically "release" could be also paired with "alloc"
Collaborator
There was a problem hiding this comment.
same for priskv_release_async
yapple
force-pushed
the
feature/zero-copy
branch
6 times, most recently
from
ca2fa6f to
42a73ba
Compare
Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
yapple
force-pushed
the
feature/zero-copy
branch
from
42a73ba to
5b30287
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[Please provide a clear and concise description of your changes here]
feat: Initial support for zero-copy commands (all server commands are empty implementations for now)
alloc/seal/acquire/release
to support alloc command, we add a member alloc_length in priskv_request, and add a member addr_offset in priskv_response
to support acquire command, we also use the new member addr_offset in priskv_response
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to PrisKV! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to PrisKV's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.