Skip to content

Comments

[Feature] support shm mapping and register#29

Open
DwyaneShi wants to merge 2 commits intoaibrix:devfrom
DwyaneShi:haiyang/cuda-shm
Open

[Feature] support shm mapping and register#29
DwyaneShi wants to merge 2 commits intoaibrix:devfrom
DwyaneShi:haiyang/cuda-shm

Conversation

@DwyaneShi
Copy link
Collaborator

Pull Request Description

This PR is to support exchanging shm info between server and client.

On server side:

  • get shm fd
  • register with cuda api (ensure all pages are pinned down)
  • send pid and shm fd to new connections

On client side:

  • get pid and shm fd after handshake
  • mmap shm
  • register with cuda api (to make it accessible by gpus)

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to PrisKV! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to PrisKV's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@yapple
Copy link

yapple commented Jan 30, 2026

Compile failed with PRISKV_USE_CUDA=0

/usr/bin/ld: /tmp/ccfG8uqG.o: undefined reference to symbol 'dlsym@@GLIBC_2.2.5'
/usr/bin/ld: //lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line

@DwyaneShi
Copy link
Collaborator Author

Compile failed with PRISKV_USE_CUDA=0

/usr/bin/ld: /tmp/ccfG8uqG.o: undefined reference to symbol 'dlsym@@GLIBC_2.2.5'
/usr/bin/ld: //lib/x86_64-linux-gnu/libdl.so.2: error adding symbols: DSO missing from command line

fixed

@DwyaneShi DwyaneShi closed this Jan 31, 2026
@DwyaneShi DwyaneShi reopened this Jan 31, 2026
@DwyaneShi DwyaneShi force-pushed the haiyang/cuda-shm branch 2 times, most recently from c99dd47 to 83b9a28 Compare February 7, 2026 01:24
Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
Server does not need to be cuda registered based on e2e testing

Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants