Skip to content

Update contract templates #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
whoabuddy merged 47 commits into from
Apr 10, 2025
Merged

Update contract templates #128

whoabuddy merged 47 commits into from
Apr 10, 2025

Conversation

@whoabuddy
Copy link
Contributor

@whoabuddy whoabuddy commented Apr 7, 2025 •
edited
Loading

Pulling in the latest from aibtcdev/aibtcdev-contracts#36

Fixes:

Done:

  • update action contract templates
  • update extension templates
  • update core proposal templates
  • update trait refs to v3
  • update contract registry
  • update core proposal registry
  • update contract generator service
  • update contract generator script

Left to do:

  • finish comparing clarity updates to registry entries for template params
  • base bootstrap: review multi timed vault generation (one too many?)
  • double check deployment order against clarinet
  • update contract deployer service
  • update contract deployer script
  • configure timed vault: allow timed vault contract as param see note below

Blockers:

  • action extension for configuring a timed vault is hardcoded to the main timed vault. if we implement multiple versions we need a way to fix. using a single timed vault of each type for now.

whoabuddy added 30 commits April 7, 2025 13:12
@whoabuddy
fix: update action contracts and types
2c96cf1
@whoabuddy
fix: update trait refs to -v3, deploy link in commit details
4d1034d 
aibtc-dao-traits-v3: https://explorer.hiro.so/txid/ST1B1CCG03BTGDAAR49R3KM34V48P3RPAQ4P2SSJG.aibtc-dao-traits-v3?chain=testnet

aibtc-dao-v3: https://explorer.hiro.so/txid/ST1B1CCG03BTGDAAR49R3KM34V48P3RPAQ4P2SSJG.aibtc-dao-v3?chain=testnet
@whoabuddy
feat: Update DAO templates with upstream contract changes
3b15ba6
@whoabuddy
fix: add new extensions, remove old singletons
99e6ab6 
Also adds some missing template variables to all contracts including some lines missed in action contracts.
@whoabuddy
fix: add latest core proposal templates matching contracts
9b76dc6
@whoabuddy
chore: abc's in order
bc379c4
@whoabuddy
refactor: Split registry files into categorized arrays for improved r…
e301f4c 
…eadability
@whoabuddy
fix: update subcategories based on new extensions
7ebf58a
@whoabuddy
fix: reorder extensions, add new payments and timed vault entries
f8795d8
@whoabuddy
fix: update contract registry with latest
ae6570f
@whoabuddy
fix: bootstrap template var names
99505df
@whoabuddy
fix: update core proposal registry with latest
119019b
@whoabuddy
fix: separate registry into its own folder
7e048d9
@whoabuddy
refactor: separate const defs for contract registry
9c95dbe 
File was getting huuuuuuuge
@whoabuddy
refactor: organize by folder for each registry file
fe7464c
@whoabuddy
refactor: separate core proposals by target contract
b57f482 
Similar to split for main contract registry, this produces much easier to read chunks of template info for generating the contracts.
@whoabuddy
fix: pull template var to top
80415f7
@whoabuddy
fix: missed a save
02e83ce
@whoabuddy
fix: remove legacy proposal contracts
771d949
@whoabuddy
fix: update template placeholders in contracts
35d2356
@whoabuddy
refactor: Update contract registry keys and template paths for timed …
9564f26 
…vault actions
@whoabuddy
refactor: Remove duplicate messaging_contract entry in actions.ts
b7fb038
@whoabuddy
refactor: Update contract registry with token contract references
24ba4aa
@whoabuddy
feat: Centralize deployment order with visualization and validation t…
3a42bcf 
…ools
@whoabuddy
feat: Add deployment order registry for DAO contract deployment sequence
824c0ad
@whoabuddy
feat: Add support for generating multiple numbered contract copies
ef3fd0f
@whoabuddy
feat: Add multiple timed vault contract extensions to DAO initialization
459e1f2
@whoabuddy
refactor: Remove duplicate ContractCopyConfig and move generateTimedV…
d0ea265 
…aultBootstrapCode to DaoContractGenerator
@whoabuddy
feat: Add multiple contract copy support for timed vault contracts in…
9c3df35 
… generate-dao script
@whoabuddy
fix: Update timed vault contract variable name in bootstrap initializ…
1e65831 
…ation template
whoabuddy added 17 commits April 9, 2025 16:29
@whoabuddy
fix: use it prefix in templates, general formatting
fb53acb
@whoabuddy
fix: remove examples dir
ca39896
@whoabuddy
refactor: rename folder to match registry name
09eac72
@whoabuddy
feat: Update DAO core proposal registry with correct paths and missin…
0915088 
…g files

This commit makes the following changes:
- Update import paths in the main registry file
- Correct template paths to include "dao/" prefix
- Create missing registry files for proposal categories
- Ensure consistent file structure for core proposal registries
@whoabuddy
fix: move deployment order into contract registry
7dc6fc1
@whoabuddy
fix: undefined dao token
458158a
@whoabuddy
fix: use addr ref for sbtc contract
d208728
@whoabuddy
fix: remaining undefined template refs
8fe1451
@whoabuddy
refactor: Dynamically generate numbered contract references in bootst…
080d99b 
…rap proposal
@whoabuddy
fix: cleanup and formatting
be85cdd 
Looks like I clobbered my other commit will have to reconcile re: undefined values.
@whoabuddy
fix: resolve bootstrap def conflict
57217ca
@whoabuddy
fix: reduce to single timed vault for testnet deployment
d7c5d42 
There is an issue with the action contracts and knowing which timed vault to call. There are a few ways we can fix it but streamlining it to one of each type for now so we can test out everything around it while we implement.
@whoabuddy
refactor: Separate template functions from template variables to reso…
7d684fa 
…lve type error
@whoabuddy
feat: Add contract copies config and deployment order validation
64d7bb9
@whoabuddy
fix: revert to single timed vaults for now
91260b7
@whoabuddy
fix: match new return type in upstream
7b44abf
@whoabuddy
fix: add more delay between deploys
feb7e6d 
We were hitting 429s toward the end and script stops in the middle.
@whoabuddy whoabuddy mentioned this pull request Apr 10, 2025
Closed
4 tasks
@whoabuddy whoabuddy merged commit 4be79e3 into main Apr 10, 2025
@whoabuddy whoabuddy deleted the fix/update-contract-templates branch April 10, 2025 17:54
@whoabuddy whoabuddy mentioned this pull request Apr 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@whoabuddy