Fix sporadic test failures#692
Open
mugiwaraluffy56 wants to merge 1 commit intoaiondemand:developfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change(s)
Change Type: Fixed
Change Category: Internal
Changelog Entry: Fix sporadic test failures
tests were randomly failing (~2 out of 9 runs), found two issues:
logged_in_user()was missingtry/finallyso if a test failed inside thewithblock,keycloak_openid.introspectnever got restored and the mockleaked into the next tests (403 instead of 401, mocked requests not firing, etc.)
some timestamp comparisons used
<instead of<=, on a fast machine thetimestamps can be equal so the assertion fails
How to Test
run
pytest src/testsa few times and check the failures from #688 don't show upChecklist
Related Issues
Closes #688