-
Notifications
You must be signed in to change notification settings - Fork 63
feat(!): Major rework to blessed #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
|
I'm not sure whether we should switch to blessed or not, but in my opinion, it's not good to add too many features in one PR. Maybe we can split the enhancement parts into other small PRs if possible. If they are coupled with blessed, we can add them later. I don't know if we can make the backend (curses or blessed) selectable, so the user can specify using curses for existing TUI apps. |

Info
This would somewhat address and/or entirely close:
Changes
Option'senablevalue toFalse) visually distinct to show un-selectableTODO:
1. Increased flexibility for coloring options?Can specify a color to an
Option()now, as well as specifying the disabled color and pagination tip colors topick(); in addition, because not using curses, ansi codes can be used anywhere and interpreted appropriately.2. Ensure closer parity to existingpicklibrary currently* Biggest gap is the existing screen option; don't know that that would be even possible to do while leveraging blessed? It seems not likely, unless I'm missing something.* Notably: theexample/position.pyis the only example that is not working equivalentlyI'm convinced that switching to blessed entirely breaks interoperability with curses - this would need to be a discussion, I think? for this reason, I've set it to a major version upgrade - though I fear that this change will disrupt a good group of people who chose this package (bc they already had a curses app and wanted a nice pre-built menuing utility)? I am unsure what percentage of people that use this package absolutely require it to be interoperable with curses, but by going to blessed, I am of the opinion that it removes that option completely.
I would appreciate any further input/thoughts as well, thanks!