fix: improve data.pack scan reliability and path handling#12
Open
ibraved wants to merge 1 commit intoakioukun:mainfrom
Open
fix: improve data.pack scan reliability and path handling#12ibraved wants to merge 1 commit intoakioukun:mainfrom
ibraved wants to merge 1 commit intoakioukun:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Scan Tree was missing many files from
data.pack.The likely causes were in scanning/parsing robustness:
container_lenand skipping valid entries.std::filesystem::pathfor in-pack virtual paths, which can behave unexpectedly for non-filesystem path data.What This PR Changes
File changed:
DataPack.cppread_u32_le(...)instead of direct pointer casts.sanitize_pack_path(...):\to//is_likely_pack_path(...)before accepting entries.path_lenvalidation aligned to byte max (<= 255).AddFileToTree(...)to avoidstd::filesystem::pathfor virtual in-pack paths:Why This Fixes It
Validation
data.packrepro case to confirm all expected files appear in Scan Tree.Scope
DataPack.cpp.