Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statements#3
Open
akshay-joshi wants to merge 1 commit intomasterfrom
Open
Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statements#3akshay-joshi wants to merge 1 commit intomasterfrom
akshay-joshi wants to merge 1 commit intomasterfrom
Conversation
akshay-joshi
force-pushed
the
get_policy_ddl
branch
6 times, most recently
from
8064d16 to
dab0fee
Compare
akshay-joshi
force-pushed
the
get_policy_ddl
branch
2 times, most recently
from
9912555 to
a86ff9f
Compare
|
I'm wondering if we want to consider making
Otherwise, now the regression tests pass for me on (a86ff9f), which is on top of master (2d7b247). Patch example: |
Just to note moving this discussion to -hackers, I did not realize it was posted at the time I wrote this. |
akshay-joshi
force-pushed
the
get_policy_ddl
branch
4 times, most recently
from
54cebf9 to
0d505dc
Compare
akshay-joshi
force-pushed
the
get_policy_ddl
branch
2 times, most recently
from
afee950 to
8ba841c
Compare
akshay-joshi
force-pushed
the
get_policy_ddl
branch
2 times, most recently
from
59e0e36 to
2421b38
Compare
This patch introduces a new system function:
pg_get_policy_ddl(regclass table, name policy_name, bool pretty),
which reconstructs the CREATE POLICY statement for the specified policy.
Usage examples:
SELECT pg_get_policy_ddl('rls_table', 'pol1'); -- non-pretty formatted DDL
SELECT pg_get_policy_ddl('rls_table', 'pol1', true); -- pretty formatted DDL
SELECT pg_get_policy_ddl(16564, 'pol1'); -- non-pretty formatted DDL
SELECT pg_get_policy_ddl(16564, 'pol1', true); -- pretty formatted DDL
Reference: PG-163
Author: Akshay Joshi <akshay.joshi@enterprisedb.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
akshay-joshi
force-pushed
the
get_policy_ddl
branch
from
2421b38 to
aa75f76
Compare
akshay-joshi
pushed a commit
that referenced
this pull request
Feb 5, 2026
cost_tidrangescan() was setting the disabled_nodes value correctly, and then immediately resetting it to zero, due to poor code editing on my part. materialized_finished_plan correctly set matpath.parent to zero, but forgot to also set matpath.parallel_workers = 0, causing an access to uninitialized memory in cost_material. (This shouldn't result in any real problem, but it makes valgrind unhappy.) reparameterize_path was dereferencing a variable before verifying that it was not NULL. Reported-by: Tom Lane <tgl@sss.pgh.pa.us> (issue #1) Reported-by: Michael Paquier <michael@paquier.xyz> (issue #1) Diagnosed-by: Lukas Fittl <lukas@fittl.com> (issue #1) Reported-by: Zsolt Parragi <zsolt.parragi@percona.com> (issue #2) Reported-by: Richard Guo <guofenglinux@gmail.com> (issue #3) Discussion: http://postgr.es/m/CAN4CZFPvwjNJEZ_JT9Y67yR7C=KMNa=LNefOB8ZY7TKDcmAXOA@mail.gmail.com Discussion: http://postgr.es/m/aXrnPgrq6Gggb5TG@paquier.xyz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pg_get_policy_ddl() function to reconstruct CREATE POLICY statements
This patch introduces a new system function:
pg_get_policy_ddl(regclass table, name policy_name, bool pretty),
which reconstructs the CREATE POLICY statement for the specified policy.
Usage examples:
SELECT pg_get_policy_ddl('rls_table', 'pol1', false); -- non-pretty formatted DDL
SELECT pg_get_policy_ddl('rls_table', 'pol1', true); -- pretty formatted DDL
Reference: PG-163
Author: Akshay Joshi akshay.joshi@enterprisedb.com