Second series of improvements: #56
Conversation
-Fix screensaver background image ( When app is not in foreground ) -Fix colors in dark mode. -Fix "new conversation" -Fix "Archived conversation" -Fix "Chats in community panel" -Fix Allow to download medias and export to other apps via content-hub -Fix Optimize scaling and font-size and layout -Add a notice while the application is loading to inform users about the necessity to disable suspend with "Ubuntu tweaks" to get notifications.
|
Seems so good, i check download files, scale seems also ok, tooltip for notifications is awesome |
|
this does not seem to launch on ubuntu touch focal will test later on 24.04-1.0 |
|
for change log i believe it is using the commit message to a degree, we can ask in the openstore group about that |
Hum indeed this was QtQuick 2.9 before, I will change it, it should be fine |
|
Hopefully that's better like this... I don't have anymore any focal device to test. |
|
yes this launches, thanks |
|
I was able to start it on noble. But on focal it didn't start. |
|
@mihaelmilea Even with the last commits? Can you run this to see what's happening? |
|
Yes, this is the only one I installed today. On my noble N100 it worked and I can confirm it is the last version - it displays the info about notifications on the start screen. `journalctl -r | grep whatsweb | head -n 10 Oct 15 22:12:59 N10 ayatana-indicat[6440]: an application with id 'alefnode.whatsweb_whatsweb_0.3.0.desktop' is not installed Oct 15 22:08:22 N10 audit[5118]: AVC apparmor="STATUS" operation="profile_replace" info="same as current profile, skipping" profile="unconfined" name="whatsweb.pparent_whatsweb_0.3.3//qwe_helper" pid=5118 comm="apparmor_parser" Oct 15 22:08:22 N10 audit[5118]: AVC apparmor="STATUS" operation="profile_replace" info="same as current profile, skipping" profile="unconfined" name="whatsweb.pparent_whatsweb_0.3.3" pid=5118 comm="apparmor_parser" Oct 15 22:08:22 N10 audit[5117]: AVC apparmor="STATUS" operation="profile_replace" info="same as current profile, skipping" profile="unconfined" name="whatsweb.pparent_push_0.3.3" pid=5117 comm="apparmor_parser" Oct 15 22:08:01 N10 audit[1070]: AVC apparmor="STATUS" operation="profile_load" profile="unconfined" name="whatsweb.pparent_whatsweb_0.3.3//qwe_helper" pid=1070 comm="apparmor_parser" Oct 15 22:08:01 N10 audit[1070]: AVC apparmor="STATUS" operation="profile_load" profile="unconfined" name="whatsweb.pparent_whatsweb_0.3.3" pid=1070 comm="apparmor_parser" Oct 15 22:08:01 N10 audit[1069]: AVC apparmor="STATUS" operation="profile_load" profile="unconfined" name="whatsweb.pparent_push_0.3.3" pid=1069 comm="apparmor_parser" Oct 15 22:08:01 N10 audit[997]: AVC apparmor="STATUS" operation="profile_load" profile="unconfined" name="whatsweb.pparent_whatsweb_0.3.3//qwe_helper" pid=997 comm="apparmor_parser" Oct 15 22:08:01 N10 audit[997]: AVC apparmor="STATUS" operation="profile_load" profile="unconfined" name="whatsweb.pparent_whatsweb_0.3.3" pid=997 comm="apparmor_parser" Oct 15 22:08:01 N10 audit[996]: AVC apparmor="STATUS" operation="profile_load" profile="unconfined" name="whatsweb.pparent_push_0.3.3" pid=996 comm="apparmor_parser" |
|
@mihaelmilea Yes but this is strange because @Fuseteam reported the same bug, and that it was solved with my latest commit. Can you make sure that you are running this version (it's inside the zip): https://github.com/alefnode/ubports-apps/actions/runs/18535215454/artifacts/4278957665 If it still does not work, would help if you can run the terminal command above and give me the output. |
|
What you sent me is 0.3.1 - should I go ahead and install this? |
|
@mihaelmilea Ok I see you are actually running my branded version of the app "whatsweb.pparent" that I use for my tests, but here we are testing the version of @alefnode "alefnode.whatsweb" that will be published in the store. Sorry for the confusion. You can uninstall "whatsweb.pparent". |
Yes, you can uninstall whatsweb.pparent, and go ahead with this version that was automatically built by github. |
|
Ok, the click 0.3.1 installed and started on focal, thank you! |
|
On focal, I can open the "Archived" only when the left menu is visible by touching the left upper three dots. On noble, I can view "Archived" without the left menu being visible.
|
Hum this is very strange, I don't see why the behavior should be different in focal and noble, it is the same code. @Fuseteam can you reproduce? |
|
I add a small adjustment that I had forgotten that could provoke notifications duplicate in some cases. |
|
Well, my bad: after I restarted (again) the app, I cannot reproduce the "error" anymore. Sorry about that! |
|
@mihaelmilea @Fuseteam Are the scaling, font size, and layout of the chatview similar in noble and focal? |
Yes. |
|
weird i can't seem to open archived or starred messages on focal 🤔 I don't have an fairphone 4 on noble (but i do have different device on it) but the scaling is otherwise fine on focal @pparent76 |
|
seems like i have to toggle the sidebar to see starred messages and archived messages, just restarted whatsweb too |
|
Stared messages is not supposed to work, but archived messages it is strange that it does not. |
|
From where are you accessing archived message? (Just to make sure there is not another way to access them that I may have missed) |
|
Do you see the same behaviour on new chat button? |
|
I add an Important thing that I had forgotten: clear the download cache, so that the app does not take more and more storage as you download files. Maybe you can have a quick check that everything is still ok with this last commit. |
|
Also I was wondering, do you have at least one archived conversation, and the "Archived conversation" appears on top of your chat? Because I'm thinking that the behavior might be different if you don't have any archived conversation. But then it is less useful to access an empty list of archived conversations. |
|
Yes, I have archived conversation and the entry "Archived" appears on top of the conversations and has a number of unread messages on its right. |
|
@mihaelmilea But it currently works for you right? |
|
Yes, it does. |
from the context menu
the new chat button works fine
I do, but do not see "archived conversation" at the top of my chat 🤔 |
|
Ok then it is normal that it does not work if you access Archived conversation from context menu, that opens from the right-hand corner "3 dots" icon. This context menu items will not be fixed in that release. Do you actually have some archived conversations with recent messages in your account? If not this might be why you don't see it at the top of your chatlist. Or else I don't understand why you don't have it on top of your chatlist. |
|
@alefnode Anyway I think we're good to go for me, for this PR, as I won't fix button in context menu in the right hand corner for now, in this revision. I will do later when I have time for a next revision. |
|
Perfecto, is good also for me, i am going to try to fix changelog after this merge |
ah yeah that explains it, thanks |
|
Hello again, I installed the version from openstore. It starts on noble but it doesn't start on focal. Here's the log: https://dpaste.com/DGESTF5U4 |
|
@mihaelmilea Thank's for reporting! I guess this is because 2 branches were merged at the same time. I let you investigate, as I will sadly not be available this week-end. |
|
should i rollback the other merge? |
|
@alefnode I guess it can be a quick fix, in the mean time. |
|
Here the MR #58 |
|
Should be fixed now in open-store |
|
0.3.2 appears in open-store for noble but it doesn't appear for focal - I'll check again in a bit and report. |
|
it's same as last versions |
|
Yes, it showed up in open-store on my focal device as well. Thank you all very much, amazing work! |
4 participants
The following improvements are brought with this pull request:
It should now have all the major functionalities of whatsapp web working, and the UI should be mostly ok.
It would be a nice bonus if some users want to do a bit of testing at least for the scaling part @alefnode @mihaelmilea may be @Fuseteam ?
@alefnode Note that the changelog seems broken on openstore
After that I will do a pause, but what could remain to do is:
-Create an internal configuration menu to tweak the app (Scaling, Font Size, Enable/Disable notifications, gpu, screensaver, background audio in webview, quick copy to clipboard, ... )
-Minor bug correction, and UI tweaking
-Clean code to make it more easy to maintain.